Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2332103003:
Define a minimum delay time for processing live regions on the same node. (Closed)
|
Created:
4 years, 3 months ago by David Tseng Modified:
4 years, 3 months ago CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDefine a minimum delay time for processing live regions on the same node.
This distinguishes the time we use to queue live region output vs the time we
use to drop live regions if fired on the same ancestry.
BUG=641548, 641548, 641786
TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/89cf7451ed3e6091f24c641309fe057f92817cf9
Cr-Commit-Position: refs/heads/master@{#418369}
Patch Set 1 #Patch Set 2 : Change min same node ms to 20 ms. #Messages
Total messages: 19 (12 generated)
Description was changed from ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG= ========== to ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org
Description was changed from ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548,641786 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Define a minimum delay time for dropping live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548,641786 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Define a minimum delay time for processing live regions on the same node.the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548,641786 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Define a minimum delay time for processing live regions on the same node.the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548,641786 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Define a minimum delay time for processing live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548,641786 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
I am going to make a similar change on the Mac. It seems that Voiceover drops ARIA live region changed notifications if they come without a 20 millisecond delay from one another. I found this by reading Apple's WebKit source code If you want to use the same constant (20 MS) go ahead. If there are reasons to stick with 500 MS, perhaps I should use 500 MS on the Mac as well. The problem might be in Docs (without Braille Mode enabled) where rapid pressing of the cursor keys might not read anything? In any case, it's better for both parts of the code to use the same constant. -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Thanks for the note. I'll use 20ms as well. Note that there are two constants ChromeVox uses. A min delay between processing live regions on the same node (introduced here as 50ms) and a 500ms delay for deciding to flush speech output (vs queue). On Tue, Sep 13, 2016 at 10:53 AM, Nektarios Paisios <nektar@google.com> wrote: > I am going to make a similar change on the Mac. > It seems that Voiceover drops ARIA live region changed notifications if > they come without a 20 millisecond delay from one another. > I found this by reading Apple's WebKit source code > If you want to use the same constant (20 MS) go ahead. If there are > reasons to stick with 500 MS, perhaps I should use 500 MS on the Mac as > well. The problem might be in Docs (without Braille Mode enabled) where > rapid pressing of the cursor keys might not read anything? > In any case, it's better for both parts of the code to use the same > constant. > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
nektar@chromium.org changed reviewers: + nektar@chromium.org
lgtm
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Define a minimum delay time for processing live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548,641786 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Define a minimum delay time for processing live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548,641786 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Define a minimum delay time for processing live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548,641786 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Define a minimum delay time for processing live regions on the same node. This distinguishes the time we use to queue live region output vs the time we use to drop live regions if fired on the same ancestry. BUG=641548,641548,641786 TEST=type rapidly in Docs; verify all key presses are echoed with braille mode off. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/89cf7451ed3e6091f24c641309fe057f92817cf9 Cr-Commit-Position: refs/heads/master@{#418369} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/89cf7451ed3e6091f24c641309fe057f92817cf9 Cr-Commit-Position: refs/heads/master@{#418369} |
