media/base/android/media_decoder_job.cc - Issue 23321004: capture a top java exception on certain Samsung devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_decoder_job.cc

Issue 23321004: capture a top java exception on certain Samsung devices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: return error code Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/android/media_decoder_job.cc

diff --git a/media/base/android/media_decoder_job.cc b/media/base/android/media_decoder_job.cc

index 33b48302b0ec8f7dc447318efe424f9bf5a7a157..64beaf1aaa52af1529db49605cfbfc778b2167da 100644

--- a/media/base/android/media_decoder_job.cc

+++ b/media/base/android/media_decoder_job.cc

@@ -224,7 +224,11 @@ void MediaDecoderJob::DecodeInternal(

if (needs_flush) {

DVLOG(1) << "DecodeInternal needs flush.";

input_eos_encountered_ = false;

- media_codec_bridge_->Reset();

+ MediaCodecStatus reset_status = media_codec_bridge_->Reset();

+ if (MEDIA_CODEC_OK != reset_status) {

+ callback.Run(reset_status, start_presentation_timestamp, 0);

+ return;

+ }

}

MediaCodecStatus input_status = MEDIA_CODEC_INPUT_END_OF_STREAM;