Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2332093002: [Merge to M54] arc: Add a global 5 minute timeout for ARC opt-in (Closed)

Created:
4 years, 3 months ago by Luis Héctor Chávez
Modified:
4 years, 3 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, asvitkine+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge to M54] arc: Add a global 5 minute timeout for ARC opt-in This should be a safety net for *all* boot failures we have (or might have). This change replaces the flag |waiting_for_reply_| with a base::OneShotTimeout that will log the situation and report a timeout error to the user. BUG=645233 TEST=Intentionally make ARC not send the reply, see the UI, ARC is still running. Review-Url: https://codereview.chromium.org/2323043003 Cr-Commit-Position: refs/heads/master@{#417770} (cherry picked from commit 3d3317a6e0dde5de7effb4406c4b60bb7aa91bb5) R=holte@chromium.org, yusukes@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/bb3ec13c84a856dfc36d80b51fc6455626b1ad4e

Patch Set 1 #

Patch Set 2 : rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.h View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 8 chunks +25 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_optin_uma.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Luis Héctor Chávez
PTAL yusukes: c/b/c/arc holte: tools/metrics/histograms/histograms.xml N.B. this was not a clean merge: the pre-submit hook ...
4 years, 3 months ago (2016-09-12 20:38:29 UTC) #2
Yusuke Sato
arc/ lgtm
4 years, 3 months ago (2016-09-12 20:44:05 UTC) #3
Luis Héctor Chávez
also ping?
4 years, 3 months ago (2016-09-13 23:50:12 UTC) #4
Steven Holte
On 2016/09/13 23:50:12, Luis Héctor Chávez wrote: > also ping? histograms lgtm
4 years, 3 months ago (2016-09-13 23:53:40 UTC) #5
Luis Héctor Chávez
4 years, 3 months ago (2016-09-14 00:02:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bb3ec13c84a856dfc36d80b51fc6455626b1ad4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698