Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2611)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2332073002: Adds a test that verifies that navigating in the unload handler while (Closed)
Patch Set: remove TODO Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 6c4675a18a59a0d9e09809eb1af7b6d5deb61f7f..1c8e004f162b0cbd28cf09a7c4fe420f48eac35c 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1686,8 +1686,6 @@ void RenderFrameImpl::OnSwapOut(
// The swap can fail when the frame is detached during swap (this can
// happen while running the unload handlers). When that happens, delete
// the proxy.
- // TODO(lfg): Handle the case where a navigation started during swap.
- // See https://crbug.com/590054 for more details.
proxy->frameDetached(blink::WebRemoteFrameClient::DetachType::Swap);
return;
}
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698