chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java - Issue 2332063002: Mark flaky chrome_public tests with @RetryOnFailure Batch 3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java

Issue 2332063002: Mark flaky chrome_public tests with @RetryOnFailure Batch 3 (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java

index 89af2773c0a4fad65b341ccda9efd7844a7ca924..4a2a68cc787ffbd9029426d4e0d39bacee6ecd77 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java

@@ -12,6 +12,7 @@ import org.chromium.base.ThreadUtils;

import org.chromium.base.test.util.CommandLineFlags;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.Restriction;

+import org.chromium.base.test.util.RetryOnFailure;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.test.ChromeTabbedActivityTestBase;

@@ -161,12 +162,14 @@ public class UpdateMenuItemHelperTest extends ChromeTabbedActivityTestBase {

@MediumTest

@Feature({"Omaha"})

+ @RetryOnFailure

public void testCurrentVersionIsOlder() throws Exception {

checkUpdateMenuItemIsShowing("0.0.0.0", "1.2.3.4");

}

@MediumTest

@Feature({"Omaha"})

+ @RetryOnFailure

public void testCurrentVersionIsSame() throws Exception {

checkUpdateMenuItemIsNotShowing("1.2.3.4", "1.2.3.4");

}

@@ -179,6 +182,7 @@ public class UpdateMenuItemHelperTest extends ChromeTabbedActivityTestBase {

@MediumTest

@Feature({"Omaha"})

+ @RetryOnFailure

public void testNoVersionKnown() throws Exception {

checkUpdateMenuItemIsNotShowing("1.2.3.4", "0");

}

@@ -186,6 +190,7 @@ public class UpdateMenuItemHelperTest extends ChromeTabbedActivityTestBase {

@MediumTest

@Feature({"Omaha"})

@Restriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)

+ @RetryOnFailure

public void testMenuItemNotShownInOverview() throws Exception {

checkUpdateMenuItemIsShowing("0.0.0.0", "1.2.3.4");