Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

Issue 2332063002: Mark flaky chrome_public tests with @RetryOnFailure Batch 3 (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
index 7745c383bf815473be8b1241ecbcc7fab5d4f3ce..250e73e21a29788112519b38efedbb567ba66673 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
@@ -11,6 +11,7 @@ import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.Callback;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CommandLineFlags;
+import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.OfflinePageModelObserver;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.SavePageCallback;
@@ -110,12 +111,14 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
}
@SmallTest
+ @RetryOnFailure
public void testLoadOfflinePagesWhenEmpty() throws Exception {
List<OfflinePageItem> offlinePages = getAllPages();
assertEquals("Offline pages count incorrect.", 0, offlinePages.size());
}
@SmallTest
+ @RetryOnFailure
public void testAddOfflinePageAndLoad() throws Exception {
loadUrl(mTestPage);
savePage(SavePageResult.SUCCESS, mTestPage);
@@ -144,6 +147,7 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
}
@SmallTest
+ @RetryOnFailure
public void testGetPageByBookmarkId() throws Exception {
loadUrl(mTestPage);
savePage(SavePageResult.SUCCESS, mTestPage);
@@ -160,6 +164,7 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
}
@SmallTest
+ @RetryOnFailure
public void testDeleteOfflinePage() throws Exception {
deletePage(BOOKMARK_ID, DeletePageResult.SUCCESS);
loadUrl(mTestPage);
@@ -196,6 +201,7 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
}
@SmallTest
+ @RetryOnFailure
public void testCheckPagesExistOffline() throws Exception {
// If we save a page, then it should exist in the result.
loadUrl(mTestPage);
@@ -216,6 +222,7 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
}
@SmallTest
+ @RetryOnFailure
public void testGetRequestsInQueue() throws Exception {
String url = "https://www.google.com/";
String namespace = "custom_tabs";
@@ -248,12 +255,14 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
}
@SmallTest
+ @RetryOnFailure
public void testOfflinePageBridgeDisabledInIncognito() throws Exception {
initializeBridgeForProfile(true);
assertEquals(null, mOfflinePageBridge);
}
@SmallTest
+ @RetryOnFailure
public void testRemoveRequestsFromQueue() throws Exception {
String url = "https://www.google.com/";
String namespace = "custom_tabs";

Powered by Google App Engine
This is Rietveld 408576698