Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2332043002: Fix incorrect error message for ScriptProcessorNode (Closed)

Created:
4 years, 3 months ago by Raymond Toy
Modified:
4 years, 3 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect error message for ScriptProcessorNode The value printed when the number of output channels exceeded the maximum value was incorrectly printing the number of input channels. The test correctly checked this, but the expected result was incorrectly checking for the incorrect value. BUG=645806 TEST=dom-exceptions.html updated expectations Committed: https://crrev.com/5196ddbea6597d66d839cb25f7acee9855491bc0 Cr-Commit-Position: refs/heads/master@{#418071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Raymond Toy
PTAL.
4 years, 3 months ago (2016-09-12 18:25:03 UTC) #2
hongchan
lgtm
4 years, 3 months ago (2016-09-12 18:41:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332043002/1
4 years, 3 months ago (2016-09-12 20:28:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 22:05:13 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 22:07:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5196ddbea6597d66d839cb25f7acee9855491bc0
Cr-Commit-Position: refs/heads/master@{#418071}

Powered by Google App Engine
This is Rietveld 408576698