Fix get_device_configuration.py/device_utils.py

Fix get_device_configuration.py/device_utils.py

- Fix get_device_configuration.py to use build_device.GetAttachedDevices
without the () as it is now a list not a method since () was added at
build_device.GetAttachedDevices
- Fix device_utils.py to check for unicode as well as str since the config
push_libraries was loading had unicode for the device id

NOTRY=true
BUG=267773
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263317

[David Trainor- moved to gerrit, 2014-04-11 01:18:54]

Saw a quick bug with managed build.  ptal thanks!

[jbudorick, 2014-04-11 01:20:50]

lgtm

https://codereview.chromium.org/233203003/diff/20001/build/android/gyp/util/b...
File build/android/gyp/util/build_device.py (right):

https://codereview.chromium.org/233203003/diff/20001/build/android/gyp/util/b...
build/android/gyp/util/build_device.py:22: GetAttachedDevices =
android_commands.GetAttachedDevices
yaron has a patch for this one already:

https://codereview.chromium.org/233733003/

[Yaron, 2014-04-11 01:30:33]

The CQ bit was checked by yfriedman@chromium.org

[Yaron, 2014-04-11 01:30:36]

The CQ bit was unchecked by yfriedman@chromium.org

[David Trainor- moved to gerrit, 2014-04-11 17:35:54]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2014-04-11 17:37:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtrainor@chromium.org/233203003/40001

[commit-bot: I haz the power, 2014-04-11 17:37:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 17:37:07]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[craigdh, 2014-04-11 17:44:31]

lgtm w/ nit

https://codereview.chromium.org/233203003/diff/40001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/233203003/diff/40001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:23: if isinstance(device, str) or
isinstance(device, unicode):
Don't do this. You can just do a single isinstance(device, basestring) to cover
both of these.

[David Trainor- moved to gerrit, 2014-04-11 18:34:10]

https://chromiumcodereview.appspot.com/233203003/diff/40001/build/android/pyl...
File build/android/pylib/device/device_utils.py (right):

https://chromiumcodereview.appspot.com/233203003/diff/40001/build/android/pyl...
build/android/pylib/device/device_utils.py:23: if isinstance(device, str) or
isinstance(device, unicode):
On 2014/04/11 17:44:32, craigdh wrote:
> Don't do this. You can just do a single isinstance(device, basestring) to
cover
> both of these.

oh even better thanks!

[jbudorick, 2014-04-11 19:45:03]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-04-11 19:46:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtrainor@chromium.org/233203003/50001

[commit-bot: I haz the power, 2014-04-11 19:49:56]

Change committed as 263317

[David Trainor- moved to gerrit, 2014-04-11 20:58:27]

On 2014/04/11 19:49:56, I haz the power (commit-bot) wrote:
> Change committed as 263317

Thanks for landing this.  Got distracted on another bug :(.

[jbudorick, 2014-04-11 21:01:41]

On 2014/04/11 20:58:27, David Trainor wrote:
> On 2014/04/11 19:49:56, I haz the power (commit-bot) wrote:
> > Change committed as 263317
> 
> Thanks for landing this.  Got distracted on another bug :(.

No worries. Thanks for fixing it!