Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 2332013002: DevTools: Allow PageUp to fall through text editor (Closed)

Created:
4 years, 3 months ago by einbinder
Modified:
4 years, 3 months ago
Reviewers:
lushnikov, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Allow PageUp to fall through text editor This is in preperation of CodeMirror-based console prompt. BUG=607690 Committed: https://crrev.com/bfd101e48d3242aed02f6209790e2687915237e5 Cr-Commit-Position: refs/heads/master@{#418072}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 2 chunks +22 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
einbinder
Ptal. See https://github.com/codemirror/CodeMirror/issues/4209
4 years, 3 months ago (2016-09-12 17:02:50 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2332013002/diff/1/third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css File third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css (right): https://codereview.chromium.org/2332013002/diff/1/third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css#newcode365 third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css:365: .CodeMirror textarea{ nit: spaces before { here and ...
4 years, 3 months ago (2016-09-12 17:15:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332013002/20001
4 years, 3 months ago (2016-09-12 17:57:19 UTC) #7
lushnikov
lgtm, thanks
4 years, 3 months ago (2016-09-12 20:10:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 22:06:13 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 22:09:38 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bfd101e48d3242aed02f6209790e2687915237e5
Cr-Commit-Position: refs/heads/master@{#418072}

Powered by Google App Engine
This is Rietveld 408576698