Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2332003003: Disable flaky ConditionalCacheDeletionHelperBrowserTest.TimeAndURL on mac. (Closed)

Created:
4 years, 3 months ago by lazyboy
Modified:
4 years, 3 months ago
Reviewers:
msramek
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky ConditionalCacheDeletionHelperBrowserTest.TimeAndURL on mac. We proabably need to use an increased |timeout_ms| value to fix, I'm not sure what increased value would make it work, disabling for now. TBR=msramek@chromium.org BUG=646119 Committed: https://crrev.com/d8abf8fed5564a5fddcd1810ac00404cd528cf98 Cr-Commit-Position: refs/heads/master@{#418059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332003003/1
4 years, 3 months ago (2016-09-12 20:55:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 21:45:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d8abf8fed5564a5fddcd1810ac00404cd528cf98 Cr-Commit-Position: refs/heads/master@{#418059}
4 years, 3 months ago (2016-09-12 21:48:43 UTC) #7
msramek
4 years, 3 months ago (2016-09-13 13:43:30 UTC) #9
Message was sent while issue was closed.
LGTM, will see what I can do.

Powered by Google App Engine
This is Rietveld 408576698