Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: testing/scripts/run_telemetry_as_googletest.py

Issue 2331993003: Updating isolate scripts to read in chartjson telemetry results (Closed)
Patch Set: Removing unwanted code Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« testing/scripts/run_gpu_integration_test_as_googletest.py ('K') | « testing/scripts/run_gpu_integration_test_as_googletest.py ('k') | testing/scripts/run_telemetry_benchmark_as_googletest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/scripts/run_telemetry_as_googletest.py
diff --git a/testing/scripts/run_telemetry_as_googletest.py b/testing/scripts/run_telemetry_as_googletest.py
index f7bdcc00c0880554c17ba6de8a7383af11ec8065..82491845dc6273f5cfd88b806b7eccb104583fae 100755
--- a/testing/scripts/run_telemetry_as_googletest.py
+++ b/testing/scripts/run_telemetry_as_googletest.py
@@ -39,6 +39,15 @@ def main():
required=True)
parser.add_argument('--xvfb', help='Start xvfb.', action='store_true')
args, rest_args = parser.parse_known_args()
+ # Remove the chartjson extra arg until this script cares about chartjson
+ # results from telemetry
+ index = 0
+ for arg in rest_args:
+ if '--isolated-script-test-chartjson-output' in arg:
+ rest_args.pop(index)
+ break
+ index += 1
Ken Russell (switch to Gerrit) 2016/09/19 20:27:57 Same here.
eyaich1 2016/09/20 12:52:02 Done.
+
xvfb_proc = None
openbox_proc = None
xcompmgr_proc = None
« testing/scripts/run_gpu_integration_test_as_googletest.py ('K') | « testing/scripts/run_gpu_integration_test_as_googletest.py ('k') | testing/scripts/run_telemetry_benchmark_as_googletest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698