Fix SyzyASAN build, by removing base/bits.h include.

Fix SyzyASAN build, by removing base/bits.h include.

This include would otherwise introduce a circular build file dependency
under the is_syzyasan configuration.

BUG=645819
Committed: https://crrev.com/a1a9b338ff36a0166204d82cd8f90bf4923ff7de
Cr-Commit-Position: refs/heads/master@{#417982}

[Sigurður Ásgeirsson, 2016-09-12 14:48:15]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 14:48:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2016-09-12 14:49:33]

siggi@chromium.org changed reviewers:
+ primiano@chromium.org

[Sigurður Ásgeirsson, 2016-09-12 14:49:33]

PTAL - unfortunately this duplicates a line of code. Hopefully I can dump the
windows shim soonish and get rid of this code altogether.

[Primiano Tucci (use gerrit), 2016-09-12 15:44:22]

ah right. LGTM

https://codereview.chromium.org/2331973002/diff/1/base/allocator/winheap_stub...
File base/allocator/winheap_stubs_win.cc (right):

https://codereview.chromium.org/2331973002/diff/1/base/allocator/winheap_stub...
base/allocator/winheap_stubs_win.cc:30: size_t Align(size_t size, size_t
alignment) {
At this point probably not worth having a separate function and just putting the
code down there will make everything more readable (down there you have the
comment that says "round up" which clears the ambiguity about the intent of this
function).
Having said that, not a huge deal at all.
Maybe do that only if you are really bored, or just tick commit otherwise.
Whateverz.

[commit-bot: I haz the power, 2016-09-12 15:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 15:59:43]

Dry run: This issue passed the CQ dry run.

[Sigurður Ásgeirsson, 2016-09-12 17:15:13]

The CQ bit was checked by siggi@chromium.org

[Sigurður Ásgeirsson, 2016-09-12 17:15:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2331973002/#ps20001
(title: "Address primiano's comments.")

[Sigurður Ásgeirsson, 2016-09-12 17:15:22]

Thanks, committing.

https://codereview.chromium.org/2331973002/diff/1/base/allocator/winheap_stub...
File base/allocator/winheap_stubs_win.cc (right):

https://codereview.chromium.org/2331973002/diff/1/base/allocator/winheap_stub...
base/allocator/winheap_stubs_win.cc:30: size_t Align(size_t size, size_t
alignment) {
On 2016/09/12 15:44:22, Primiano Tucci wrote:
> At this point probably not worth having a separate function and just putting
the
> code down there will make everything more readable (down there you have the
> comment that says "round up" which clears the ambiguity about the intent of
this
> function).
> Having said that, not a huge deal at all.
> Maybe do that only if you are really bored, or just tick commit otherwise.
> Whateverz.

Done.

[commit-bot: I haz the power, 2016-09-12 17:15:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 18:42:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-12 18:44:19]

Description was changed from

==========
Fix SyzyASAN build, by removing base/bits.h include.

This include would otherwise introduce a circular build file dependency
under the is_syzyasan configuration.

BUG=645819
==========

to

==========
Fix SyzyASAN build, by removing base/bits.h include.

This include would otherwise introduce a circular build file dependency
under the is_syzyasan configuration.

BUG=645819

Committed: https://crrev.com/a1a9b338ff36a0166204d82cd8f90bf4923ff7de
Cr-Commit-Position: refs/heads/master@{#417982}
==========

[commit-bot: I haz the power, 2016-09-12 18:44:20]

Patchset 2 (id:??) landed as
https://crrev.com/a1a9b338ff36a0166204d82cd8f90bf4923ff7de
Cr-Commit-Position: refs/heads/master@{#417982}