Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: src/interpreter/bytecode-generator.h

Issue 2331913002: [interpreter] Use clearer names for context related functions. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.h
diff --git a/src/interpreter/bytecode-generator.h b/src/interpreter/bytecode-generator.h
index b00ead46507739ac20f4cc063e23dcd18395fba8..f0a5846afd66dc890465748ada2bfe078a37ac88 100644
--- a/src/interpreter/bytecode-generator.h
+++ b/src/interpreter/bytecode-generator.h
@@ -127,6 +127,12 @@ class BytecodeGenerator final : public AstVisitor<BytecodeGenerator> {
void VisitGeneratorPrologue();
rmcilroy 2016/09/12 10:17:02 nit - could you move this down below the new Build
+ void BuildNewLocalActivationContext();
+ void BuildLocalActivationContextInitialization();
+ void BuildNewLocalBlockContext(Scope* scope);
+ void BuildNewLocalCatchContext(Variable* variable, Scope* scope);
+ void BuildNewLocalWithContext(Scope* scope);
+
void VisitArgumentsObject(Variable* variable);
void VisitRestArgumentsArray(Variable* rest);
void VisitCallSuper(Call* call);
@@ -136,12 +142,7 @@ class BytecodeGenerator final : public AstVisitor<BytecodeGenerator> {
void VisitClassLiteralStaticPrototypeWithComputedName(Register name);
void VisitThisFunctionVariable(Variable* variable);
void VisitNewTargetVariable(Variable* variable);
- void VisitNewLocalFunctionContext();
- void VisitBuildLocalActivationContext();
void VisitBlockDeclarationsAndStatements(Block* stmt);
- void VisitNewLocalBlockContext(Scope* scope);
- void VisitNewLocalCatchContext(Variable* variable, Scope* scope);
- void VisitNewLocalWithContext(Scope* scope);
void VisitFunctionClosureForContext();
void VisitSetHomeObject(Register value, Register home_object,
LiteralProperty* property, int slot_number = 0);
« no previous file with comments | « no previous file | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698