Source/core/dom/MessageEvent.cpp - Issue 23319002: Set MessageEvent.source to the newly created port for shared workers' connect events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/MessageEvent.cpp

Issue 23319002: Set MessageEvent.source to the newly created port for shared workers' connect events (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/MessageEvent.cpp

diff --git a/Source/core/dom/MessageEvent.cpp b/Source/core/dom/MessageEvent.cpp

index ce6e8fa0deb0aebb1d68207d4170dc359e2aaa01..2e0bd3b042d9ec9be2471af8b48abe7fcfb494fa 100644

--- a/Source/core/dom/MessageEvent.cpp

+++ b/Source/core/dom/MessageEvent.cpp

@@ -54,7 +54,7 @@ MessageEvent::MessageEvent(const AtomicString& type, const MessageEventInit& ini

ScriptWrappable::init(this);

}

-MessageEvent::MessageEvent(const String& origin, const String& lastEventId, PassRefPtr<DOMWindow> source, PassOwnPtr<MessagePortArray> ports)

+MessageEvent::MessageEvent(const String& origin, const String& lastEventId, PassRefPtr<EventTarget> source, PassOwnPtr<MessagePortArray> ports)

: Event(eventNames().messageEvent, false, false)

, m_dataType(DataTypeScriptValue)

, m_origin(origin)

@@ -65,7 +65,7 @@ MessageEvent::MessageEvent(const String& origin, const String& lastEventId, Pass

ScriptWrappable::init(this);

}

abarth-chromium 2013/08/19 19:24:58 For example, the ASSERT could go here (and in othe

-MessageEvent::MessageEvent(PassRefPtr<SerializedScriptValue> data, const String& origin, const String& lastEventId, PassRefPtr<DOMWindow> source, PassOwnPtr<MessagePortArray> ports)

+MessageEvent::MessageEvent(PassRefPtr<SerializedScriptValue> data, const String& origin, const String& lastEventId, PassRefPtr<EventTarget> source, PassOwnPtr<MessagePortArray> ports)

: Event(eventNames().messageEvent, false, false)

, m_dataType(DataTypeSerializedScriptValue)

, m_dataAsSerializedScriptValue(data)

« Source/core/dom/MessageEvent.h ('K') | « Source/core/dom/MessageEvent.h ('k') | Source/core/dom/MessageEvent.idl » ('j') | Source/core/dom/MessageEvent.idl » ('J')