Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2331843004: MIPS64: Add support for DINS to disassembler (Closed)

Created:
4 years, 3 months ago by ivica.bogosavljevic
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Add support for DINS to disassembler BUG= Committed: https://crrev.com/28bd11814872f3ef7e3349017c788277a7497766 Cr-Commit-Position: refs/heads/master@{#39375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/mips64/disasm-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ivica.bogosavljevic
PTAL When debugging and using print_all_code function, sometime we get ASSERT failures (notably in octane ...
4 years, 3 months ago (2016-09-12 14:41:31 UTC) #2
akos.palfi.imgtec
LGTM, thanks!
4 years, 3 months ago (2016-09-12 14:48:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331843004/1
4 years, 3 months ago (2016-09-13 09:18:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 09:20:24 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 09:21:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28bd11814872f3ef7e3349017c788277a7497766
Cr-Commit-Position: refs/heads/master@{#39375}

Powered by Google App Engine
This is Rietveld 408576698