chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java - Issue 2331773002: Take Murmur2 hash of untransformed icon when creating WebAPK part 2/2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

Issue 2331773002: Take Murmur2 hash of untransformed icon when creating WebAPK part 2/2 (Closed)

Patch Set: Merge branch 'master' into icon_hasher2 Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

index 5742747ee87d01aced2f9076f5fbbc777ce0c8ae..ddda953cd5761994732ffab7492f0d27f7b74608 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

@@ -114,7 +114,7 @@ public class WebApkUpdateManager implements ManifestUpgradeDetector.Callback {

public void updateAsync(ManifestUpgradeDetector.FetchedManifestData data) {

String packageName = mUpgradeDetector.getWebApkPackageName();

nativeUpdateAsync(data.startUrl, data.scopeUrl, data.name, data.shortName, data.iconUrl,

- Long.toString(data.iconMurmur2Hash), data.icon, data.displayMode, data.orientation,

+ data.iconMurmur2Hash, data.icon, data.displayMode, data.orientation,

data.themeColor, data.backgroundColor, mUpgradeDetector.getManifestUrl(),

packageName, mVersionCode);

}