Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 233163003: Fix android_arm64 target for experimental ndk (Closed)

Created:
6 years, 8 months ago by rmcilroy
Modified:
6 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix android_arm64 target for experimental ndk BUG=354405 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Makefile.android View 2 chunks +4 lines, -4 lines 0 comments Download
M build/android.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
PTAL. Note, I also changed the target platform for other architectures since the NDK checked ...
6 years, 8 months ago (2014-04-10 15:59:21 UTC) #1
ulan
lgtm
6 years, 8 months ago (2014-04-10 16:03:27 UTC) #2
rmcilroy
6 years, 8 months ago (2014-04-10 21:29:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20659 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698