Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Unified Diff: android_webview/BUILD.gn

Issue 2331573003: build full 64bit WebView (Closed)
Patch Set: fix a error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/system_webview_apk_tmpl.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/BUILD.gn
diff --git a/android_webview/BUILD.gn b/android_webview/BUILD.gn
index 90949095041e38ff459b30d08fb080bca95e68b1..99f74fdf10fa37a0959d9b7368df69a6a0ac93fc 100644
--- a/android_webview/BUILD.gn
+++ b/android_webview/BUILD.gn
@@ -156,6 +156,9 @@ android_assets("monochrome_webview_assets") {
"//third_party/icu:icu_assets",
"//v8:v8_external_startup_data_assets",
]
+ if (android_64bit_target_cpu && build_apk_secondary_abi) {
+ deps += [ ":v8_snapshot_secondary_abi_assets" ]
+ }
}
android_assets("assets") {
@@ -396,6 +399,20 @@ shared_library("libwebviewchromium") {
}
if (android_64bit_target_cpu) {
+ android_assets("v8_snapshot_secondary_abi_assets") {
+ _secondary_abi_out_dir =
+ get_label_info("//v8($android_secondary_abi_toolchain)", "root_out_dir")
+ assert(android_64bit_target_cpu,
+ "32-bit targets shouldn't have secondary abi")
+ arch_suffix = "32"
+ renaming_sources = [ "$_secondary_abi_out_dir/snapshot_blob.bin" ]
+ renaming_destinations = [ "snapshot_blob_$arch_suffix.bin" ]
+ disable_compression = true
+ deps = [
+ "//v8($android_secondary_abi_toolchain)",
+ ]
+ }
+
shared_library("monochrome") {
deps = [
":webview_entry_point",
« no previous file with comments | « no previous file | android_webview/system_webview_apk_tmpl.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698