Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2417)

Unified Diff: android_webview/BUILD.gn

Issue 2331573003: build full 64bit WebView (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/BUILD.gn
diff --git a/android_webview/BUILD.gn b/android_webview/BUILD.gn
index 90949095041e38ff459b30d08fb080bca95e68b1..1231043f291555cd35dbdaffc3b4dfcc7dc8d6d1 100644
--- a/android_webview/BUILD.gn
+++ b/android_webview/BUILD.gn
@@ -156,6 +156,10 @@ android_assets("monochrome_webview_assets") {
"//third_party/icu:icu_assets",
"//v8:v8_external_startup_data_assets",
]
+ if (android_64bit_target_cpu &&
+ (!defined(merge_64bit_webview) || !merge_64bit_webview)) {
+ deps += [ ":v8_snapshot_secondary_abi_assets" ]
+ }
}
android_assets("assets") {
@@ -396,6 +400,29 @@ shared_library("libwebviewchromium") {
}
if (android_64bit_target_cpu) {
+ group("webviewchromium_secondary_abi_lib") {
+ public_deps = [
+ ":libwebviewchromium($android_secondary_abi_toolchain)",
+ ]
+ }
+
+ android_assets("v8_snapshot_secondary_abi_assets") {
+ _secondary_abi_toolchain_name =
+ get_label_info(android_secondary_abi_toolchain, "name")
+ _secondary_abi_out_dir =
+ rebase_path("$root_build_dir/$_secondary_abi_toolchain_name")
+
+ assert(android_64bit_target_cpu,
+ "32-bit targets shouldn't have secondary abi")
+ arch_suffix = "32"
+ renaming_sources = [ "$_secondary_abi_out_dir/snapshot_blob.bin" ]
+ renaming_destinations = [ "snapshot_blob_$arch_suffix.bin" ]
+ disable_compression = true
+ deps = [
+ "//v8($android_secondary_abi_toolchain)",
+ ]
+ }
+
shared_library("monochrome") {
deps = [
":webview_entry_point",
« no previous file with comments | « no previous file | android_webview/system_webview_apk_tmpl.gni » ('j') | android_webview/system_webview_apk_tmpl.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698