Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: build/config/android/config.gni

Issue 2331573003: build full 64bit WebView (Closed)
Patch Set: address comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains common system config stuff for the Android build. 5 # This file contains common system config stuff for the Android build.
6 6
7 if (is_android) { 7 if (is_android) {
8 assert(rebase_path("//", root_build_dir) == "../../", 8 assert(rebase_path("//", root_build_dir) == "../../",
9 "Android output directory must be nested 2 levels within src/ (" + 9 "Android output directory must be nested 2 levels within src/ (" +
10 "e.g.: out-gn/Debug). http://crbug.com/412935") 10 "e.g.: out-gn/Debug). http://crbug.com/412935")
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 # Disables process isolation when building _incremental targets. 126 # Disables process isolation when building _incremental targets.
127 # Required for Android M+ due to SELinux policies (stronger sandboxing). 127 # Required for Android M+ due to SELinux policies (stronger sandboxing).
128 disable_incremental_isolated_processes = false 128 disable_incremental_isolated_processes = false
129 129
130 # Speed up incremental compiles by compiling only changed files. 130 # Speed up incremental compiles by compiling only changed files.
131 enable_incremental_javac = false 131 enable_incremental_javac = false
132 132
133 # Adds intrumentation to each function. Writes a file with the order that 133 # Adds intrumentation to each function. Writes a file with the order that
134 # functions are called at startup. 134 # functions are called at startup.
135 use_order_profiling = false 135 use_order_profiling = false
136
137 # Only build 64-bit binaries in 64-bit WebView APK. 32-bit apps will not be
138 # supported; for development only.
139 build_64bit_only_webview = false
jbudorick 2016/09/16 16:23:35 As this is webview-specific, it seems like it shou
Torne 2016/09/16 16:37:57 It'll also have an effect on the monochrome APK.
michaelbai 2016/09/16 20:05:55 Since there are 2 separated variable, this one is
136 } 140 }
137 141
138 # We need a second declare_args block to make sure we are using the overridden 142 # We need a second declare_args block to make sure we are using the overridden
139 # value of the arguments set above. 143 # value of the arguments set above.
140 declare_args() { 144 declare_args() {
141 # Speed up dexing using dx --incremental. 145 # Speed up dexing using dx --incremental.
142 enable_incremental_dx = is_java_debug 146 enable_incremental_dx = is_java_debug
143 } 147 }
144 148
149 if (defined(merge_64bit_webview_and_monochrome) &&
jbudorick 2016/09/16 16:23:35 I agree with torne -- this should be defined upstr
150 merge_64bit_webview_and_monochrome) {
151 build_64bit_only_webview = true
152 }
153
145 # Neither of these should ever be used for release builds since they are 154 # Neither of these should ever be used for release builds since they are
146 # somewhat experimental and dx --incremental is known to not produce 155 # somewhat experimental and dx --incremental is known to not produce
147 # byte-for-byte identical output. 156 # byte-for-byte identical output.
148 assert(!(enable_incremental_dx && !is_java_debug)) 157 assert(!(enable_incremental_dx && !is_java_debug))
149 assert(!(enable_incremental_javac && !is_java_debug)) 158 assert(!(enable_incremental_javac && !is_java_debug))
150 159
151 # Host stuff ----------------------------------------------------------------- 160 # Host stuff -----------------------------------------------------------------
152 161
153 # Defines the name the Android build gives to the current host CPU 162 # Defines the name the Android build gives to the current host CPU
154 # architecture, which is different than the names GN uses. 163 # architecture, which is different than the names GN uses.
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 "//build/toolchain/android:${android_secondary_abi_cpu}" 333 "//build/toolchain/android:${android_secondary_abi_cpu}"
325 } 334 }
326 } 335 }
327 } 336 }
328 337
329 declare_args() { 338 declare_args() {
330 # Enables used resource whitelist generation. Set for official builds only 339 # Enables used resource whitelist generation. Set for official builds only
331 # as a large amount of build output is generated. 340 # as a large amount of build output is generated.
332 enable_resource_whitelist_generation = is_android && is_official_build 341 enable_resource_whitelist_generation = is_android && is_official_build
333 } 342 }
OLDNEW
« android_webview/BUILD.gn ('K') | « android_webview/system_webview_apk_tmpl.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698