Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2331543002: [turbofan] Switch from a whitelist to a blacklist for NeedsFrameStateInput (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Switch from a whitelist to a blacklist for NeedsFrameStateInput The whitelist is populated with those inline intrinsics that are lowered in JSIntrinsicInlining and were not previously blacklisted. Thus the only additional FrameStates this CL adds are those where the caller tries to call the INLINE version of an intrinsic but ends up calling the RUNTIME version instead. R=bmeurer@chromium.org BUG=chromium:644631 Committed: https://crrev.com/58325e616d068ab589a91b6f80896e28df395f93 Cr-Commit-Position: refs/heads/master@{#39357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
M src/compiler/linkage.cc View 2 chunks +23 lines, -22 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-644631.js View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
adamk
4 years, 3 months ago (2016-09-09 22:37:36 UTC) #1
Benedikt Meurer
Nice, thanks Adam. LGTM.
4 years, 3 months ago (2016-09-10 17:04:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331543002/1
4 years, 3 months ago (2016-09-12 15:47:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 16:12:19 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 16:13:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58325e616d068ab589a91b6f80896e28df395f93
Cr-Commit-Position: refs/heads/master@{#39357}

Powered by Google App Engine
This is Rietveld 408576698