Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4508)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java

Issue 2331533002: Mark flaky chrome_public tests with @RetryOnFailure Batch 2 (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
index 5698468d4a1b3d78a440c2d592f506b4858b852e..031568a718f214a4442e2da7de72f4055496caad 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
@@ -18,6 +18,7 @@ import android.text.TextUtils;
import android.util.Base64;
import org.chromium.base.test.util.Restriction;
+import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler.OverrideUrlLoadingResult;
@@ -219,12 +220,14 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity
}
@SmallTest
+ @RetryOnFailure
public void testNavigationFromTimer() throws InterruptedException {
loadUrlAndWaitForIntentUrl(
mTestServer.getURL(NAVIGATION_FROM_TIMEOUT_PAGE), false, false, true);
}
@SmallTest
+ @RetryOnFailure
public void testNavigationFromTimerInSubFrame() throws InterruptedException {
loadUrlAndWaitForIntentUrl(
mTestServer.getURL(NAVIGATION_FROM_TIMEOUT_PARENT_FRAME_PAGE), false,
@@ -232,6 +235,7 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity
}
@SmallTest
+ @RetryOnFailure
public void testNavigationFromUserGesture() throws InterruptedException {
loadUrlAndWaitForIntentUrl(
mTestServer.getURL(NAVIGATION_FROM_USER_GESTURE_PAGE), true, true, true);
@@ -245,12 +249,14 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity
}
@SmallTest
+ @RetryOnFailure
public void testNavigationFromXHRCallback() throws InterruptedException {
loadUrlAndWaitForIntentUrl(
mTestServer.getURL(NAVIGATION_FROM_XHR_CALLBACK_PAGE), true, true, true);
}
@SmallTest
+ @RetryOnFailure
public void testNavigationFromXHRCallbackInSubFrame() throws InterruptedException {
loadUrlAndWaitForIntentUrl(
mTestServer.getURL(NAVIGATION_FROM_XHR_CALLBACK_PARENT_FRAME_PAGE), true,
@@ -258,6 +264,7 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity
}
@SmallTest
+ @RetryOnFailure
public void testNavigationFromXHRCallbackAndShortTimeout() throws InterruptedException {
loadUrlAndWaitForIntentUrl(
mTestServer.getURL(NAVIGATION_FROM_XHR_CALLBACK_AND_SHORT_TIMEOUT_PAGE),
@@ -265,6 +272,7 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity
}
@SmallTest
+ @RetryOnFailure
public void testNavigationFromXHRCallbackAndLongTimeout() throws InterruptedException {
loadUrlAndWaitForIntentUrl(
mTestServer.getURL(NAVIGATION_FROM_XHR_CALLBACK_AND_LONG_TIMEOUT_PAGE),
@@ -272,6 +280,7 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity
}
@SmallTest
+ @RetryOnFailure
public void testNavigationWithFallbackURL()
throws InterruptedException, UnsupportedEncodingException {
String fallbackUrl = mTestServer.getURL(FALLBACK_LANDING_PATH);
@@ -283,6 +292,7 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity
}
@SmallTest
+ @RetryOnFailure
public void testNavigationWithFallbackURLInSubFrame()
throws InterruptedException, UnsupportedEncodingException {
// The replace_text parameters for NAVIGATION_WITH_FALLBACK_URL_PAGE, which is loaded in
@@ -316,6 +326,7 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity
}
@SmallTest
+ @RetryOnFailure
public void testRedirectionFromIntent() throws InterruptedException {
Intent intent = new Intent(Intent.ACTION_VIEW,
Uri.parse(mTestServer.getURL(NAVIGATION_FROM_JAVA_REDIRECTION_PAGE)));

Powered by Google App Engine
This is Rietveld 408576698