Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: PRESUBMIT.py

Issue 2331423005: Re-add common.gypi to help fix closure_compilation. (Closed)
Patch Set: remove presubmit check Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 0076836a086d7d5f7530b3f8caff282c84ad9f98..b9d8e19aa7f96dc195e750813ec3e0b9195005d1 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1247,24 +1247,6 @@ def _CheckForAnonymousVariables(input_api, output_api):
return []
-def _CheckCygwinShell(input_api, output_api):
- source_file_filter = lambda x: input_api.FilterSourceFile(
- x, white_list=(r'.+\.(gyp|gypi)$',))
- cygwin_shell = []
-
- for f in input_api.AffectedSourceFiles(source_file_filter):
- for linenum, line in f.ChangedContents():
- if 'msvs_cygwin_shell' in line:
- cygwin_shell.append(f.LocalPath())
- break
-
- if cygwin_shell:
- return [output_api.PresubmitError(
- 'These files should not use msvs_cygwin_shell (the default is 0):',
- items=cygwin_shell)]
- return []
-
-
def _CheckUserActionUpdate(input_api, output_api):
"""Checks if any new user action has been added."""
if any('actions.xml' == input_api.os_path.basename(f) for f in
@@ -1998,7 +1980,6 @@ def _CommonChecks(input_api, output_api):
source_file_filter=lambda x: x.LocalPath().endswith('.grd')))
results.extend(_CheckSpamLogging(input_api, output_api))
results.extend(_CheckForAnonymousVariables(input_api, output_api))
- results.extend(_CheckCygwinShell(input_api, output_api))
results.extend(_CheckUserActionUpdate(input_api, output_api))
results.extend(_CheckNoDeprecatedCSS(input_api, output_api))
results.extend(_CheckNoDeprecatedJS(input_api, output_api))
« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698