Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2331413002: [unittests] Reduce compilation overhead of opcodes-unittest.cc. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[unittests] Reduce compilation overhead of opcodes-unittest.cc. Reduce compilation time (with clang) for opcodes-unittest.cc from 1m38s to roughly 1s by not overusing the macro expansion magic. TBR=jarin@chromium.org Committed: https://crrev.com/a63997599e2596f2662905d7c138e62bbf86adaf Cr-Commit-Position: refs/heads/master@{#39365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -36 lines) Patch
M test/unittests/compiler/opcodes-unittest.cc View 2 chunks +31 lines, -36 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-13 04:39:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331413002/1
4 years, 3 months ago (2016-09-13 04:40:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 05:15:34 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 05:16:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a63997599e2596f2662905d7c138e62bbf86adaf
Cr-Commit-Position: refs/heads/master@{#39365}

Powered by Google App Engine
This is Rietveld 408576698