Chromium Code Reviews| Index: ui/android/java/res/layout/autofill_text.xml |
| diff --git a/ui/android/java/res/layout/autofill_text.xml b/ui/android/java/res/layout/autofill_text.xml |
| index a1adcadc41592b888cd39aa65a47231c27067b4a..aeb233dc895920bf042fdcaa3ca0ca080f44d361 100644 |
| --- a/ui/android/java/res/layout/autofill_text.xml |
| +++ b/ui/android/java/res/layout/autofill_text.xml |
| @@ -6,29 +6,29 @@ |
| --> |
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
| - android:id="@+id/autofill_menu_text" |
| - android:layout_width="match_parent" |
| - android:layout_height="44dp" |
| - android:minHeight="44dp" |
| - android:orientation="vertical" |
| - android:gravity="center_vertical"> |
| - <TextView android:id="@+id/autofill_label" |
| - android:layout_width="wrap_content" |
| - android:layout_height="wrap_content" |
| - android:ellipsize="end" |
| - android:singleLine="true" |
| - android:textSize="18sp" |
| - android:includeFontPadding="false" |
| - android:layout_marginStart="10dp" |
| - android:layout_marginEnd="10dp"/> |
| - <TextView android:id="@+id/autofill_sublabel" |
| - android:layout_width="wrap_content" |
| - android:layout_height="wrap_content" |
| - android:textSize="14sp" |
| - android:textColor="#8b8b8b" |
| - android:ellipsize="end" |
| - android:singleLine="true" |
| - android:includeFontPadding="false" |
| - android:layout_marginStart="10dp" |
| - android:layout_marginEnd="10dp"/> |
| + android:id="@+id/autofill_menu_text" |
| + android:layout_width="match_parent" |
|
newt (away)
2013/10/03 16:34:51
since you're not actually using the layout_width a
keishi
2013/10/04 05:52:28
Done.
|
| + android:layout_height="wrap_content" |
| + android:orientation="vertical" |
| + android:gravity="center_vertical"> |
| + |
| + <TextView android:id="@+id/autofill_label" |
| + android:layout_width="wrap_content" |
| + android:layout_height="wrap_content" |
| + android:ellipsize="end" |
| + android:singleLine="true" |
| + android:textSize="18sp" |
| + android:includeFontPadding="false" |
| + android:layout_marginStart="10dp" |
|
newt (away)
2013/10/03 16:34:51
nit: put attributes in this order:
android:id
and
keishi
2013/10/04 05:52:28
Done.
|
| + android:layout_marginEnd="10dp"/> |
| + <TextView android:id="@+id/autofill_sublabel" |
| + android:layout_width="wrap_content" |
| + android:layout_height="wrap_content" |
| + android:textSize="14sp" |
| + android:textColor="#8b8b8b" |
| + android:ellipsize="end" |
| + android:singleLine="true" |
| + android:includeFontPadding="false" |
| + android:layout_marginStart="10dp" |
| + android:layout_marginEnd="10dp"/> |
| </LinearLayout> |