Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2331373006: Enable incremental linking in release component builds (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/win/BUILD.gn ('K') | « build/config/win/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 8207107b5dc8d8e88c00f16a46bf0ce1e820dff8..5918d12f0fefe0b6fdb4a02deea1ace4e22074c2 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -180,8 +180,9 @@ component("core") {
if (is_win && is_debug && is_component_build && current_cpu == "x64") {
# Incremental linking doesn't work on this target in debug mode for
# 64-bit builds - the .ilk file gets too large and the incremental
- # link silently fails. Therefore 32-bit builds should be used for
- # fastest incremental build performance.
+ # link silently fails. Therefore 32-bit builds or 64-bit release builds
Peter Kasting 2016/09/14 01:15:17 Nit: Should this reference whatever Microsoft issu
brucedawson 2016/09/14 17:49:25 Done.
+ # (component either way) should be used for fastest incremental build
+ # performance.
configs -= [ "//build/config/win:default_incremental_linking" ]
configs += [ "//build/config/win:no_incremental_linking" ]
}
« build/config/win/BUILD.gn ('K') | « build/config/win/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698