Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2331373005: W3C auto test import CL. (Closed)

Created:
4 years, 3 months ago by blink-w3c-test-autoroller
Modified:
4 years, 2 months ago
Reviewers:
qyearsley
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

W3C auto test import CL. TBR=qyearsley@chromium.org

Patch Set 1 #

Patch Set 2 : 'Modifies TestExpectations and/or downloads new baselines for tests' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/origin-of-data-document.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/html/semantics/tabular-data/historical.html View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
blink-w3c-test-autoroller
'Modifies TestExpectations and/or downloads new baselines for tests'
4 years, 3 months ago (2016-09-13 20:14:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331373005/20001
4 years, 3 months ago (2016-09-13 20:15:00 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/295566)
4 years, 3 months ago (2016-09-13 21:32:44 UTC) #5
qyearsley
On 2016/09/13 at 21:32:44, commit-bot wrote: > Try jobs failed on following builders: > mac_chromium_rel_ng ...
4 years, 3 months ago (2016-09-14 17:23:52 UTC) #6
qyearsley
4 years, 3 months ago (2016-09-14 18:39:47 UTC) #7
On 2016/09/14 at 17:23:52, qyearsley wrote:
> On 2016/09/13 at 21:32:44, commit-bot wrote:
> > Try jobs failed on following builders:
> >   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> 
> update-w3c-test-expectations added a blank line to TestExpectations and failed
to download the baseline for origin-of-data-document.html. Not currently sure
why this is; update-w3c-test-expectations should have better logging.

I think there are two bugs that prevented this from working correctly:
 1. After running rebaseline-cl to download new baselines, baselines for new
tests are still "untracked" and won't be committed and uploaded. Ideally we want
to stage all changes ready to commit (see http://crbug.com/639410).
 2. When there are no new TestExpectation lines to add and the marker line
exists in TestExpectations, a blank line is added although it shouldn't be. A
unit test should be added and this should be fixed.

Powered by Google App Engine
This is Rietveld 408576698