Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2331363002: DevTools: Do not include RunMicrotasks event into FunctionCall. (Closed)

Created:
4 years, 3 months ago by alph
Modified:
4 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Do not include RunMicrotasks event into FunctionCall. It's not needed to enclose MicrotasksScope into FunctionCall trace event as microtasks now have a dedicated event. BUG=642228 Committed: https://crrev.com/3ca795eba291a30486050b1732b412ed56ced633 Cr-Commit-Position: refs/heads/master@{#418283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-receive-response-event-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 2 chunks +12 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alph
4 years, 3 months ago (2016-09-13 01:18:18 UTC) #2
pfeldman
lgtm
4 years, 3 months ago (2016-09-13 17:21:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331363002/1
4 years, 3 months ago (2016-09-13 17:21:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 17:27:01 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 17:28:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ca795eba291a30486050b1732b412ed56ced633
Cr-Commit-Position: refs/heads/master@{#418283}

Powered by Google App Engine
This is Rietveld 408576698