Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1827)

Unified Diff: chrome/browser/extensions/api/streams_private/streams_private_api.h

Issue 2331343005: PlzNavigate: Get StreamPrivate API to work. (Closed)
Patch Set: Pass the frame_tree_node_id, render_frame_id and render_process_id parameters to the MimeHandlerStr… Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/streams_private/streams_private_api.h
diff --git a/chrome/browser/extensions/api/streams_private/streams_private_api.h b/chrome/browser/extensions/api/streams_private/streams_private_api.h
index d1c22433f99849841e94f4b2d85c7cfa584c2091..f552fcc95054c37aadcbac2b731619f08aa73c84 100644
--- a/chrome/browser/extensions/api/streams_private/streams_private_api.h
+++ b/chrome/browser/extensions/api/streams_private/streams_private_api.h
@@ -39,12 +39,16 @@ class StreamsPrivateAPI : public BrowserContextKeyedAPI,
// should be |expected_content_size| bytes long. If the viewer is being opened
// in a BrowserPlugin, specify a non-empty |view_id| of the plugin. |embedded|
// should be set to whether the document is embedded within another document.
+ // TODO(ananta)
+ // Remove the |render_process_id| and |render_frame_id| parameters when
+ // PlzNavigate ships.
jam 2016/09/17 00:10:07 is this true? i.e. we'll still need them for the n
ananta 2016/09/17 00:23:27 Thanks. Changed the comment
ananta 2016/09/17 02:43:39 I debugged the pdf case inside an iframe. The rend
void ExecuteMimeTypeHandler(const std::string& extension_id,
content::WebContents* web_contents,
std::unique_ptr<content::StreamInfo> stream,
const std::string& view_id,
int64_t expected_content_size,
bool embedded,
+ int frame_tree_node_id,
int render_process_id,
int render_frame_id);

Powered by Google App Engine
This is Rietveld 408576698