Fix sandbox::PolicyBase leak

Fix sandbox::PolicyBase leak

StartSandboxedProcess was missing a Release call, so this was always
leaking. Use scoped_refptr instead to fix that and prevent it from
happening in the future.
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2316333003
Cr-Commit-Position: refs/heads/master@{#417313}
(cherry picked from commit b6a4ff86c730756a73d63cc882ef818fb7818a53)

BUG=646167
Committed: https://chromium.googlesource.com/chromium/src/+/dcd4529eb3a14c7107e9775801db57f3dc198cdc

[jbauman, 2016-09-13 21:56:42]

Description was changed from

==========
Fix sandbox::PolicyBase leak

StartSandboxedProcess was missing a Release call, so this was always
leaking. Use scoped_refptr instead to fix that and prevent it from
happening in the future.
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2316333003
Cr-Commit-Position: refs/heads/master@{#417313}
(cherry picked from commit b6a4ff86c730756a73d63cc882ef818fb7818a53)

BUG=646167
==========

to

==========
Fix sandbox::PolicyBase leak

StartSandboxedProcess was missing a Release call, so this was always
leaking. Use scoped_refptr instead to fix that and prevent it from
happening in the future.
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2316333003
Cr-Commit-Position: refs/heads/master@{#417313}
(cherry picked from commit b6a4ff86c730756a73d63cc882ef818fb7818a53)

BUG=646167

Committed:
https://chromium.googlesource.com/chromium/src/+/dcd4529eb3a14c7107e9775801db...
==========

[jbauman, 2016-09-13 21:56:44]

Committed patchset #1 (id:1) manually as
dcd4529eb3a14c7107e9775801db57f3dc198cdc.

[piman, 2016-09-13 22:29:07]

lgtm

https://codereview.chromium.org/2331343004/diff/1/sandbox/win/src/broker_serv...
File sandbox/win/src/broker_services.cc (right):

https://codereview.chromium.org/2331343004/diff/1/sandbox/win/src/broker_serv...
sandbox/win/src/broker_services.cc:149: // PolicyBase starts with refcount 1.
nit: could we fix that?

[jbauman, 2016-09-13 22:36:02]

On 2016/09/13 22:29:07, piman OOO back 2016-09-12 wrote:
> lgtm
> 
>
https://codereview.chromium.org/2331343004/diff/1/sandbox/win/src/broker_serv...
> File sandbox/win/src/broker_services.cc (right):
> 
>
https://codereview.chromium.org/2331343004/diff/1/sandbox/win/src/broker_serv...
> sandbox/win/src/broker_services.cc:149: // PolicyBase starts with refcount 1.
> nit: could we fix that?

cpu@ was not a fan of changing that, so I didn't bother. You can see the
discussion in https://codereview.chromium.org/2316333003#msg19