Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: src/debug/debug-evaluate.cc

Issue 2331323006: Store whether a with scope is actually a debug-eval scope in the scope info (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.h ('k') | src/factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug-evaluate.cc
diff --git a/src/debug/debug-evaluate.cc b/src/debug/debug-evaluate.cc
index 25e17a2151b2161e263578c200b1a79cf9d571bc..8970520edc3db1d9113579f3999bd49e707851d1 100644
--- a/src/debug/debug-evaluate.cc
+++ b/src/debug/debug-evaluate.cc
@@ -209,14 +209,13 @@ DebugEvaluate::ContextBuilder::ContextBuilder(Isolate* isolate,
}
for (int i = context_chain_.length() - 1; i >= 0; i--) {
+ Handle<ScopeInfo> scope_info(ScopeInfo::CreateForWithScope(
+ isolate, evaluation_context_->IsNativeContext()
+ ? Handle<ScopeInfo>::null()
+ : Handle<ScopeInfo>(evaluation_context_->scope_info())));
+ scope_info->SetIsDebugEvaluateScope();
evaluation_context_ = factory->NewDebugEvaluateContext(
- evaluation_context_,
- ScopeInfo::CreateForWithScope(
- isolate,
- evaluation_context_->IsNativeContext()
- ? Handle<ScopeInfo>::null()
- : Handle<ScopeInfo>(evaluation_context_->scope_info())),
- context_chain_[i].materialized_object,
+ evaluation_context_, scope_info, context_chain_[i].materialized_object,
context_chain_[i].wrapped_context, context_chain_[i].whitelist);
}
}
« no previous file with comments | « src/ast/scopes.h ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698