Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2331323006: Store whether a with scope is actually a debug-eval scope in the scope info (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
jgruber, marja
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Store whether a with scope is actually a debug-eval scope in the scope info This is required to be able to deserialize the scope chain from the scope info alone. BUG=v8:5215 R=marja@chromium.org,jgruber@chromium.org Committed: https://crrev.com/404bc9b67206fb3561d55fca1872588d50ccf988 Cr-Commit-Position: refs/heads/master@{#39412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -21 lines) Patch
M src/ast/scopeinfo.cc View 4 chunks +35 lines, -14 lines 0 comments Download
M src/ast/scopes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-09-14 09:26:44 UTC) #1
jgruber
lgtm
4 years, 3 months ago (2016-09-14 09:43:53 UTC) #4
marja
lgtm, but as this is dead code for now, it's hard to say much
4 years, 3 months ago (2016-09-14 10:54:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331323006/1
4 years, 3 months ago (2016-09-14 10:57:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 10:59:48 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 11:00:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/404bc9b67206fb3561d55fca1872588d50ccf988
Cr-Commit-Position: refs/heads/master@{#39412}

Powered by Google App Engine
This is Rietveld 408576698