test/webkit/ToNumber.js - Issue 2331303002: Use ICU for ID_START and ID_CONTINUE for Unicode 9 data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/webkit/ToNumber.js

Issue 2331303002: Use ICU for ID_START and ID_CONTINUE for Unicode 9 data (Closed)

Patch Set: undo the speculative fix to see if it's really necessary Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/webkit/ToNumber.js

diff --git a/test/webkit/ToNumber.js b/test/webkit/ToNumber.js

index 8d1a40b14cb04024284d2877a09b490fa1d80151..4a287600e33c5f97c8d54c384c32c229c94a8113 100644

--- a/test/webkit/ToNumber.js

+++ b/test/webkit/ToNumber.js

@@ -105,7 +105,7 @@ shouldBe("+lf", "0");

shouldBe("+ls", "0");

shouldBe("+ps", "0");

shouldBe("+oghamSpaceMark", "0");

-shouldBe("+mongolianVowelSeparator", "0");

+shouldBe("+mongolianVowelSeparator", "NaN");

shouldBe("+enQuad", "0");

shouldBe("+emQuad", "0");

shouldBe("+enSpace", "0");

@@ -129,7 +129,7 @@ shouldBe("+(lf + '1')", "1");

shouldBe("+(ls + '1')", "1");

shouldBe("+(ps + '1')", "1");

shouldBe("+(oghamSpaceMark + '1')", "1");

-shouldBe("+(mongolianVowelSeparator + '1')", "1");

+shouldBe("+(mongolianVowelSeparator + '1')", "NaN");

shouldBe("+(enQuad + '1')", "1");

shouldBe("+(emQuad + '1')", "1");

shouldBe("+(enSpace + '1')", "1");

@@ -153,7 +153,7 @@ shouldBe("+('1' + lf)", "1");

shouldBe("+('1' + ls)", "1");

shouldBe("+('1' + ps)", "1");

shouldBe("+('1' + oghamSpaceMark)", "1");

-shouldBe("+('1' + mongolianVowelSeparator)", "1");

+shouldBe("+('1' + mongolianVowelSeparator)", "NaN");

shouldBe("+('1' + enQuad)", "1");

shouldBe("+('1' + emQuad)", "1");

shouldBe("+('1' + enSpace)", "1");