Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2331293004: Restore replacedWillBeRemoved to fix compile after postMessage changes (Closed)

Created:
4 years, 3 months ago by foolip
Modified:
4 years, 3 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Restore replacedWillBeRemoved to fix compile after postMessage changes It is still in use on the M54 branch (2840) but wasn't on master. This can't be landed on master and backported, precisely because it is unused, which causes a warning, and -Werror is enabled. BUG=425896, 640825 TBR=sigbjornf@opera.com,haraken@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331293004/1
4 years, 3 months ago (2016-09-13 11:36:19 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-13 11:36:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331293004/1
4 years, 3 months ago (2016-09-13 11:37:28 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 11:39:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698