Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1674)

Issue 2331253002: Use category flush for focus events. (Closed)

Created:
4 years, 3 months ago by David Tseng
Modified:
4 years, 3 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use category flush for focus events. At times, we receive multiple focus events. This is technically fine, but it can cause lots of queued up chatter. In the linke to bug, we are reading a focus event from a previous tab. Ideally the focus event shouldn't be fired (as it once was not), but ChromeVox should be robust enough to not over speak in this case. Note that in braille, this results in a "shuffling" effect where one focus event flashes briefly before the expected event comes through. BUG=646126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1f3da58367d69ec72b038fc6085ae49df0b4a496 Cr-Commit-Position: refs/heads/master@{#419240}

Patch Set 1 #

Patch Set 2 : fix test #

Messages

Total messages: 20 (13 generated)
David Tseng
4 years, 3 months ago (2016-09-12 22:38:58 UTC) #6
dmazzoni
lgtm
4 years, 3 months ago (2016-09-15 16:40:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331253002/1
4 years, 3 months ago (2016-09-15 16:40:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/236237)
4 years, 3 months ago (2016-09-15 17:25:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331253002/20001
4 years, 3 months ago (2016-09-16 18:21:23 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 19:14:19 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:16:22 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f3da58367d69ec72b038fc6085ae49df0b4a496
Cr-Commit-Position: refs/heads/master@{#419240}

Powered by Google App Engine
This is Rietveld 408576698