Issue 2331233002: Get rid of memcmp in CFieldTree::Lookup()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2331233002: Get rid of memcmp in CFieldTree::Lookup() (Closed)

Created:
4 years, 3 months ago by Tom Sepez

Modified:
4 years, 3 months ago

Reviewers:
dsinclair

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Get rid of memcmp in CFieldTree::Lookup() Wide strings compare just fine on their own. Committed: https://pdfium.googlesource.com/pdfium/+/bb8935e9def5ad865be613eebea597a77fc7c547

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	core/fpdfdoc/cpdf_interform.cpp	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331233002/1

4 years, 3 months ago (2016-09-13 13:22:11 UTC) #5

commit-bot: I haz the power

4 years, 3 months ago (2016-09-13 13:33:19 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/bb8935e9def5ad865be613eebea597a77fc7...