Add `disposition` to SecurityPolicyViolationEvent

third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h

Index: third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h
diff --git a/third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h b/third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h
index 4524324255fad68de7cfb5995485238852609d4b..ec907c3bfd80f924c88296c6cdb19d2fb0c70173 100644
--- a/third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h
+++ b/third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.h
@@ -27,6 +27,7 @@
 
 #include "core/events/Event.h"
 #include "core/events/SecurityPolicyViolationEventInit.h"
+#include "platform/network/ContentSecurityPolicyParsers.h"

[Sergey Shekyan, 2016/09/16 05:38:02]

I am not sure if I should do this or edit DEPS, please advise.

[Mike West, 2016/09/16 07:30:35]

This is fine; //Source/core can depend on //Source/platform.

 
 namespace blink {
 
@@ -44,6 +45,12 @@ public:
     const String& violatedDirective() const { return m_violatedDirective; }
     const String& effectiveDirective() const { return m_effectiveDirective; }
     const String& originalPolicy() const { return m_originalPolicy; }
+    const AtomicString& disposition() const
+    {
+        if (m_disposition == ContentSecurityPolicyHeaderTypeEnforce)
+            return EventTypeNames::enforce;
+        return EventTypeNames::report;

[Mike West, 2016/09/16 07:30:35]

As noted above, the `EventTypeNames` bit is simply wrong. `Document::readyState`
is a good example of how we handle this pattern in other places:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Docum...

+    }
     const String& sourceFile() const { return m_sourceFile; }
     int lineNumber() const { return m_lineNumber; }
     int columnNumber() const { return m_columnNumber; }
@@ -56,6 +63,7 @@ public:
 private:
     SecurityPolicyViolationEvent(const AtomicString& type, const SecurityPolicyViolationEventInit& initializer)
         : Event(type, initializer)
+        , m_disposition(ContentSecurityPolicyHeaderTypeEnforce)
         , m_lineNumber(0)
         , m_columnNumber(0)
         , m_statusCode(0)
@@ -72,6 +80,10 @@ private:
             m_effectiveDirective = initializer.effectiveDirective();
         if (initializer.hasOriginalPolicy())
             m_originalPolicy = initializer.originalPolicy();
+        if (initializer.hasDisposition()) {
+            if (initializer.disposition() == "report")

[Mike West, 2016/09/16 07:30:35]

1. We should move this out of the `.h` file. Doesn't have to be in this CL,
though.

2. Hrm. If you're using the terms here too, then it's probably better to define
them as constants in an anonymous namespace in the `.cpp` file.

+                m_disposition = ContentSecurityPolicyHeaderTypeReport;
+        }
         if (initializer.hasSourceFile())
             m_sourceFile = initializer.sourceFile();
         if (initializer.hasLineNumber())
@@ -88,6 +100,7 @@ private:
     String m_violatedDirective;
     String m_effectiveDirective;
     String m_originalPolicy;
+    ContentSecurityPolicyHeaderType m_disposition;
     String m_sourceFile;
     int m_lineNumber;
     int m_columnNumber;