third_party/WebKit/LayoutTests/fast/events/constructors/security-policy-violation-event-constructor.html - Issue 2331213002: Add `disposition` to SecurityPolicyViolationEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/constructors/security-policy-violation-event-constructor.html

Issue 2331213002: Add `disposition` to SecurityPolicyViolationEvent (Closed)

Patch Set: Use enum in SecurityPolicyViolationEvent Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/constructors/security-policy-violation-event-constructor-expected.txt » ('j') | third_party/WebKit/Source/core/events/EventTypeNames.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/constructors/security-policy-violation-event-constructor.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/constructors/security-policy-violation-event-constructor.html b/third_party/WebKit/LayoutTests/fast/events/constructors/security-policy-violation-event-constructor.html

index 10ffd7b2ada29b202630dc6b49c090e0b01a1c3b..16528c205287c1db49f2ed11a1da1297375a6e05 100644

--- a/third_party/WebKit/LayoutTests/fast/events/constructors/security-policy-violation-event-constructor.html

+++ b/third_party/WebKit/LayoutTests/fast/events/constructors/security-policy-violation-event-constructor.html

@@ -20,6 +20,7 @@ shouldBeEmptyString("new SecurityPolicyViolationEvent('eventType').blockedURI");

shouldBeEmptyString("new SecurityPolicyViolationEvent('eventType').violatedDirective");

shouldBeEmptyString("new SecurityPolicyViolationEvent('eventType').effectiveDirective");

shouldBeEmptyString("new SecurityPolicyViolationEvent('eventType').originalPolicy");

+shouldBeEmptyString("new SecurityPolicyViolationEvent('eventType').disposition");

shouldBeEmptyString("new SecurityPolicyViolationEvent('eventType').sourceFile");

shouldBe("new SecurityPolicyViolationEvent('eventType').lineNumber", "0");

shouldBe("new SecurityPolicyViolationEvent('eventType').columnNumber", "0");

@@ -34,7 +35,7 @@ shouldBeFalse("new SecurityPolicyViolationEvent('eventType', { cancelable: false

shouldBeTrue("new SecurityPolicyViolationEvent('eventType', { cancelable: true }).cancelable");

// String members are passed.

-["documentURI", "referrer", "blockedURI", "violatedDirective", "effectiveDirective", "originalPolicy", "sourceFile"].forEach(function(member) {

+["documentURI", "referrer", "blockedURI", "violatedDirective", "effectiveDirective", "originalPolicy", "disposition", "sourceFile"].forEach(function(member) {

shouldBeEqualToString("new SecurityPolicyViolationEvent('eventType', { " + member + ": 'foo' })." + member, "foo");

});