Refine output of containers when focused

Refine output of containers when focused

some containers, such as rows in Gmail's thread view, get focused. Ensure we speak the accessible name, but don't try to speak descendants.

We only speak descendants for region and group roles. Any other role in ptractice leads to a lot of queued up output; for example, press escape while in Sheets. This results in a focus event on an application node containing almost all the content of the page.

Finally, fix the leave rule so that it also ignores formatting a leave rule for a role that was part of the speak rule. This prevents things like "... row, exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4eb367312c79163feb1ffb8901c6f1f236d1ee90
Cr-Commit-Position: refs/heads/master@{#419545}

[David Tseng, 2016-09-12 20:38:38]

Description was changed from

==========
Refine output of containers when focused and enforce focusable|focused invariant

some containers, such as rows in Gmail's thread view, get focused. Ensure we
speak the accessible name or the descendants but not both.

In some situations, such as in Google Sheets (when pressing escape), a node will
receive focus but not actually be focusable. While Blink/AX should probably fix
this and it may be a symtom of other issues, work around it in ChromeVox as it
causes us to attempt reading everything under the application node.

Finally, fix the leave rule so that it also ignores formatting a leave rule for
a role that was part of the speak rule. This prevents things like "... row,
exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
==========

to

==========
Refine output of containers when focused and enforce focusable|focused invariant

some containers, such as rows in Gmail's thread view, get focused. Ensure we
speak the accessible name or the descendants but not both.

In some situations, such as in Google Sheets (when pressing escape), a node will
receive focus but not actually be focusable. While Blink/AX should probably fix
this and it may be a symtom of other issues, work around it in ChromeVox as it
causes us to attempt reading everything under the application node.

Finally, fix the leave rule so that it also ignores formatting a leave rule for
a role that was part of the speak rule. This prevents things like "... row,
exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-09-12 20:39:00]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-09-15 16:42:05]

lgtm

[David Tseng, 2016-09-15 21:20:12]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:20:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:33:38]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[David Tseng, 2016-09-16 21:23:24]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 21:23:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:22:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:22:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-09-19 17:45:11]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-09-19 17:45:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2331163002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-19 17:45:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:45:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:45:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-09-19 19:37:42]

Description was changed from

==========
Refine output of containers when focused and enforce focusable|focused invariant

some containers, such as rows in Gmail's thread view, get focused. Ensure we
speak the accessible name or the descendants but not both.

In some situations, such as in Google Sheets (when pressing escape), a node will
receive focus but not actually be focusable. While Blink/AX should probably fix
this and it may be a symtom of other issues, work around it in ChromeVox as it
causes us to attempt reading everything under the application node.

Finally, fix the leave rule so that it also ignores formatting a leave rule for
a role that was part of the speak rule. This prevents things like "... row,
exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Refine output of containers when focused

some containers, such as rows in Gmail's thread view, get focused. Ensure we
speak the accessible name or the descendants but not both.

In some situations, such as in Google Sheets (when pressing escape), an
application node will receive focus but not actually be focusable. While
Blink/AX should probably fix this and it may be a symtom of other issues, work
around it in ChromeVox as it causes us to attempt reading everything under the
application node.

Finally, fix the leave rule so that it also ignores formatting a leave rule for
a role that was part of the speak rule. This prevents things like "... row,
exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-09-19 20:01:50]

Description was changed from

==========
Refine output of containers when focused

some containers, such as rows in Gmail's thread view, get focused. Ensure we
speak the accessible name or the descendants but not both.

In some situations, such as in Google Sheets (when pressing escape), an
application node will receive focus but not actually be focusable. While
Blink/AX should probably fix this and it may be a symtom of other issues, work
around it in ChromeVox as it causes us to attempt reading everything under the
application node.

Finally, fix the leave rule so that it also ignores formatting a leave rule for
a role that was part of the speak rule. This prevents things like "... row,
exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Refine output of containers when focused

some containers, such as rows in Gmail's thread view, get focused. Ensure we
speak the accessible name, but don't try to speak descendants.

We only speak descendants for region and group roles. Any other role in
ptractice leads to a lot of queued up output; for example, press escape while in
Sheets. This results in a focus event on an application node containing almost
all the content of the page.

Finally, fix the leave rule so that it also ignores formatting a leave rule for
a role that was part of the speak rule. This prevents things like "... row,
exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-09-19 20:04:07]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-09-19 20:04:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2331163002/#ps40001
(title: "Fix code to match test expectations; remove most descendant output.")

[commit-bot: I haz the power, 2016-09-19 20:04:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:06:31]

Description was changed from

==========
Refine output of containers when focused

some containers, such as rows in Gmail's thread view, get focused. Ensure we
speak the accessible name, but don't try to speak descendants.

We only speak descendants for region and group roles. Any other role in
ptractice leads to a lot of queued up output; for example, press escape while in
Sheets. This results in a focus event on an application node containing almost
all the content of the page.

Finally, fix the leave rule so that it also ignores formatting a leave rule for
a role that was part of the speak rule. This prevents things like "... row,
exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Refine output of containers when focused

some containers, such as rows in Gmail's thread view, get focused. Ensure we
speak the accessible name, but don't try to speak descendants.

We only speak descendants for region and group roles. Any other role in
ptractice leads to a lot of queued up output; for example, press escape while in
Sheets. This results in a focus event on an application node containing almost
all the content of the page.

Finally, fix the leave rule so that it also ignores formatting a leave rule for
a role that was part of the speak rule. This prevents things like "... row,
exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-19 21:06:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-19 21:08:38]

Description was changed from

==========
Refine output of containers when focused

some containers, such as rows in Gmail's thread view, get focused. Ensure we
speak the accessible name, but don't try to speak descendants.

We only speak descendants for region and group roles. Any other role in
ptractice leads to a lot of queued up output; for example, press escape while in
Sheets. This results in a focus event on an application node containing almost
all the content of the page.

Finally, fix the leave rule so that it also ignores formatting a leave rule for
a role that was part of the speak rule. This prevents things like "... row,
exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Refine output of containers when focused

some containers, such as rows in Gmail's thread view, get focused. Ensure we
speak the accessible name, but don't try to speak descendants.

We only speak descendants for region and group roles. Any other role in
ptractice leads to a lot of queued up output; for example, press escape while in
Sheets. This results in a focus event on an application node containing almost
all the content of the page.

Finally, fix the leave rule so that it also ignores formatting a leave rule for
a role that was part of the speak rule. This prevents things like "... row,
exited row" when moving from row to row in Gmail's thread view.

TEST=manual; chromevox_tests --gtest_filter=Output*.*
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4eb367312c79163feb1ffb8901c6f1f236d1ee90
Cr-Commit-Position: refs/heads/master@{#419545}
==========

[commit-bot: I haz the power, 2016-09-19 21:08:39]

Patchset 3 (id:??) landed as
https://crrev.com/4eb367312c79163feb1ffb8901c6f1f236d1ee90
Cr-Commit-Position: refs/heads/master@{#419545}