Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2331123002: Remove DocumentMode usage histogram. (Closed)

Created:
4 years, 3 months ago by Peter Wen
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DocumentMode usage histogram. BUG=612245 Committed: https://crrev.com/2660f43bc6c4012295e725ccac98ebb534e1d3d5 Cr-Commit-Position: refs/heads/master@{#418228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -34 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/android/feature_utilities.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/android/feature_utilities.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/metrics/android_metrics_provider.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Peter Wen
Hi Dan, This is the last CL that I'm planning to do for the document ...
4 years, 3 months ago (2016-09-12 18:57:36 UTC) #4
gone
lgtm Eh, not sure if there's anything obvious; haven't had time to look. If there's ...
4 years, 3 months ago (2016-09-12 18:59:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331123002/1
4 years, 3 months ago (2016-09-12 19:04:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/257696)
4 years, 3 months ago (2016-09-12 19:11:45 UTC) #10
Peter Wen
+asvitkine@ for metrics/histograms.
4 years, 3 months ago (2016-09-12 19:13:45 UTC) #12
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-09-12 21:05:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331123002/1
4 years, 3 months ago (2016-09-13 13:22:28 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 13:27:18 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 13:29:18 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2660f43bc6c4012295e725ccac98ebb534e1d3d5
Cr-Commit-Position: refs/heads/master@{#418228}

Powered by Google App Engine
This is Rietveld 408576698