Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2331103002: Revert of Skip apply_gerrit rebase when there is a rebase failure (Closed)

Created:
4 years, 3 months ago by rmistry
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Skip apply_gerrit rebase when there is a rebase failure (patchset #2 id:20001 of https://codereview.chromium.org/2328313002/ ) Reason for revert: The "git rebase --abort" should only happen when there is a failure during rebase not when it succeeds. Original issue's description: > Skip apply_gerrit rebase when there is a rebase failure. > > Not doing so causes a failure in the 'git checkout $base_rev' step as visible here: https://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4995 > This causes the checkout to remain in the "rebase in progress" state. > > > BUG=chromium:645955 > BUG=skia:5749 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9736fe8938e67337bb45dccf79ae8699b9625fa6 TBR=agable@chromium.org,andybons@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:645955 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b94038585684b350b2d50c43e39e8fec7b22f3c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
rmistry
Created Revert of Skip apply_gerrit rebase when there is a rebase failure
4 years, 3 months ago (2016-09-12 18:45:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331103002/1
4 years, 3 months ago (2016-09-12 18:45:37 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-12 18:45:39 UTC) #5
rmistry1
lgtm
4 years, 3 months ago (2016-09-12 18:46:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331103002/1
4 years, 3 months ago (2016-09-12 18:46:26 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 18:46:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/b94038585684b3...

Powered by Google App Engine
This is Rietveld 408576698