LayoutTests/editing/deleting/delete-inline-br.html - Issue 23311004: inline <br> does not get deleted when following some non-textual content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/deleting/delete-inline-br.html

Issue 23311004: inline <br> does not get deleted when following some non-textual content (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch with changed layout testcase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <style>

	5 div { border: 1px solid black; }

	6 </style>

	7 <script src="../../fast/js/resources/js-test-pre.js"></script>

	8 <script>

	9 function runTest() {

	10 description('Testcase for verifying that the <br> does not get deleted when inlined after some non-textual content.\nTo manually verify this issue, pl ace the caret at the start of the second line and then do a back-delete (backspa ce). The two lines should then be merged and the caret should get placed after t he text control.');

	11

	12 if (window.internals) {

	13 var selection = window.getSelection();

	14 var testElement = document.getElementById('test');

	15

	16 selection.collapse(testElement, 2);

	17 expectedCaretRect = internals.absoluteCaretBounds(document);

	18

	19 selection.collapse(testElement, 3);

	20 document.execCommand("Delete");

	21 caretRect = internals.absoluteCaretBounds(document);

	22

	23 shouldBe("caretRect.left", "expectedCaretRect.left");

	24 shouldBe("caretRect.top", "expectedCaretRect.top");

	25

	26 testElement.style.display = 'none';

	27 }

	28 }

	29 </script>

	30 <body onLoad="runTest()">

	31 <div contenteditable="true">

	32 <span id="test">text1<input type="text"/><br>text2</span>

	33 </div>

	34 <div id="description"></div>

	35 <div id="console"></div>

	36 </body>

	37 </html>

OLD	NEW