LayoutTests/editing/deleting/delete-before-block-image-2-expected.txt - Issue 23311004: inline <br> does not get deleted when following some non-textual content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/deleting/delete-before-block-image-2-expected.txt

Issue 23311004: inline <br> does not get deleted when following some non-textual content (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <img id="img" src="../resources/abe.png" style="display: block;">	1 <img id="img" style="display:block;" src="../resources/abe.png">
	leviw_travelin_and_unemployed 2013/08/19 18:14:25 Is this related somehow? Is this related somehow? arpitab_ 2013/08/22 14:12:35 Because of the existing code, after deleting the g Show quoted text On 2013/08/19 18:14:25, Levi wrote: > Is this related somehow? Because of the existing code, after deleting the given <br>, an extra placeholder <br> is inserted using the InsertNodeBefore editing command which I suspect causes the attributes rearrangement for the detached image element. (?) But after the patch, the attributes remain the way they have been specified in the test page.
2	2

3 Selection: [[object HTMLDivElement], 0]	3 Selection: [[object HTMLDivElement], 0]

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/deleting/delete-br-001.html » ('j') | LayoutTests/editing/deleting/delete-br-001.html » ('J')