Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3163)

Unified Diff: ash/shell.cc

Issue 2331093002: UMA stats for stylus usage (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index 15d9cb3f46c6d9de8c1fdda1a4c9176b6e402179..556399b939e4b35fc078819d07598e70acd7efe5 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -127,7 +127,6 @@
#include "ash/system/chromeos/power/video_activity_notifier.h"
#include "ash/touch/touch_transformer_controller.h"
#include "ash/virtual_keyboard_controller.h"
-#include "ash/wm/stylus_metrics_recorder.h"
#include "base/bind_helpers.h"
#include "base/sys_info.h"
#include "chromeos/audio/audio_a11y_controller.h"
@@ -537,9 +536,6 @@ Shell::~Shell() {
RemovePostTargetHandler(toplevel_window_event_handler_.get());
RemovePreTargetHandler(system_gesture_filter_.get());
RemovePreTargetHandler(mouse_cursor_filter_.get());
-#if defined(OS_CHROMEOS)
- RemovePreTargetHandler(stylus_metrics_recorder_.get());
-#endif
RemovePreTargetHandler(modality_filter_.get());
// TooltipController is deleted with the Shell so removing its references.
@@ -629,7 +625,6 @@ Shell::~Shell() {
#if defined(OS_CHROMEOS)
touch_transformer_controller_.reset();
- stylus_metrics_recorder_.reset();
audio_a11y_controller_.reset();
#endif // defined(OS_CHROMEOS)
@@ -851,14 +846,6 @@ void Shell::Init(const ShellInitParams& init_params) {
mouse_cursor_filter_.reset(new MouseCursorEventFilter());
PrependPreTargetHandler(mouse_cursor_filter_.get());
-#if defined(OS_CHROMEOS)
- // |stylus_metrics_recorder| records stylus metrics for certain events.
- // It does not handle/consume any events, so prepend it as a pre-target hander
- // before events are consumed elsewhere.
- stylus_metrics_recorder_.reset(new StylusMetricsRecorder());
- PrependPreTargetHandler(stylus_metrics_recorder_.get());
-#endif
-
// Create Controllers that may need root window.
// TODO(oshima): Move as many controllers before creating
// RootWindowController as possible.

Powered by Google App Engine
This is Rietveld 408576698