UMA stats for stylus usage

components/exo/shell_surface.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/exo/shell_surface.h"
 
 #include "ash/aura/wm_window_aura.h"
 #include "ash/common/shell_window_ids.h"
 #include "ash/common/wm/window_resizer.h"
 #include "ash/common/wm/window_state.h"
@@ skipping 18 matching lines @@
 #include "ui/base/accelerators/accelerator.h"
 #include "ui/gfx/path.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_observer.h"
 #include "ui/wm/core/coordinate_conversion.h"
 #include "ui/wm/core/shadow.h"
 #include "ui/wm/core/shadow_controller.h"
 #include "ui/wm/core/shadow_types.h"
 #include "ui/wm/core/window_util.h"
 
+#if defined(OS_CHROMEOS)
+#include "ash/shared/app_types.h"
+#endif
+
 DECLARE_WINDOW_PROPERTY_TYPE(std::string*)
 
 namespace exo {
 namespace {
 
 // This is a struct for accelerator keys used to close ShellSurfaces.
 const struct Accelerator {
   ui::KeyboardCode keycode;
   int modifiers;
 } kCloseWindowAccelerators[] = {
@@ skipping 884 matching lines @@
   widget_ = new ShellSurfaceWidget(this);
   widget_->Init(params);
 
   aura::Window* window = widget_->GetNativeWindow();
   window->SetName("ExoShellSurface");
   window->AddChild(surface_->window());
   window->SetEventTargeter(base::WrapUnique(new CustomWindowTargeter));
   SetApplicationId(window, &application_id_);
   SetMainSurface(window, surface_);
 
+#if defined(OS_CHROMEOS)
+  window->SetProperty(aura::client::kAppType,
+                      static_cast<int>(ash::AppType::ARC_APP));

[reveman, 2016/09/27 20:39:00]

This is incorrect. All shell surfaces are not arc apps. You can use the
kApplicationIdKey window property to detect if a window is from an arc app. It's
set to org.chromium.arc.* for arc apps. However, this type of detection doesn't
belong in exo code. Arc specific code should handle this. Maybe we can add it to
components/arc or the arc launcher code.

[xiaoyinh(OOO Sep 11-29), 2016/09/29 20:37:44]

Thanks for pointing it out. I have moved it to
arc_app_window_launcher_controller.cc

+#endif
+
   // Start tracking changes to window bounds and window state.
   window->AddObserver(this);
   ash::wm::WindowState* window_state = ash::wm::GetWindowState(window);
   window_state->AddObserver(this);
 
   // Absolete positioned shell surfaces may request the bounds that does not
   // fill the entire work area / display in maximized / fullscreen state.
   // Allow such clients to update the bounds in these states.
   if (!initial_bounds_.IsEmpty())
     window_state->set_allow_set_bounds_in_maximized(true);
@@ skipping 342 matching lines @@
       shadow_overlay_->layer()->Add(shadow->layer());
       window->AddChild(shadow_overlay_);
       shadow_overlay_->Show();
     }
     shadow_overlay_->SetBounds(shadow_bounds);
     shadow->SetContentBounds(gfx::Rect(shadow_bounds.size()));
   }
 }
 
 }  // namespace exo