Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6706)

Unified Diff: chrome/browser/page_load_metrics/browser_page_tracker_predicate.h

Issue 2331053003: Add common page filtering logic for page load metrics. (Closed)
Patch Set: refine interface Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/browser_page_tracker_predicate.h
diff --git a/chrome/browser/page_load_metrics/browser_page_tracker_predicate.h b/chrome/browser/page_load_metrics/browser_page_tracker_predicate.h
new file mode 100644
index 0000000000000000000000000000000000000000..a35982ea4f9c5d646f243defb4f771c94f2408c7
--- /dev/null
+++ b/chrome/browser/page_load_metrics/browser_page_tracker_predicate.h
@@ -0,0 +1,48 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_BROWSER_PAGE_TRACKER_PREDICATE_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_BROWSER_PAGE_TRACKER_PREDICATE_H_
+
+#include "base/macros.h"
+#include "chrome/common/page_load_metrics/page_tracker_predicate.h"
+
+namespace content {
+class NavigationHandle;
+class WebContents;
+} // namespace content
+
+namespace page_load_metrics {
+
+class PageLoadMetricsEmbedderInterface;
+
+class BrowserPageTrackerPredicate : public PageTrackerPredicate {
+ public:
+ // embedder_interface, web_contents, and navigation_handle are not owned by
+ // BrowserPageTrackerPredicate, and must outlive the
+ // BrowserPageTrackerPredicate.
+ BrowserPageTrackerPredicate(
+ PageLoadMetricsEmbedderInterface* embedder_interface,
+ content::WebContents* web_contents,
+ content::NavigationHandle* navigation_handle);
+ ~BrowserPageTrackerPredicate() override;
+
+ bool HasCommitted() override;
+ bool IsHTTPOrHTTPSUrl() override;
+ bool IsNewTabPageUrl() override;
+ bool IsChromeErrorPage() override;
+ bool IsNetworkErrorPage() override;
+ bool IsHTMLOrXHTMLPage() override;
+
+ private:
+ PageLoadMetricsEmbedderInterface* const embedder_interface_;
+ content::WebContents* const web_contents_;
+ content::NavigationHandle* const navigation_handle_;
+
+ DISALLOW_COPY_AND_ASSIGN(BrowserPageTrackerPredicate);
+};
+
+} // namespace page_load_metrics
+
+#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_BROWSER_PAGE_TRACKER_PREDICATE_H_

Powered by Google App Engine
This is Rietveld 408576698