Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/page_load_metrics/browser_page_track_decider.h

Issue 2331053003: Add common page filtering logic for page load metrics. (Closed)
Patch Set: fixup Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/browser_page_track_decider.h
diff --git a/chrome/browser/page_load_metrics/browser_page_track_decider.h b/chrome/browser/page_load_metrics/browser_page_track_decider.h
new file mode 100644
index 0000000000000000000000000000000000000000..faee5818aa646cd1925fb2f3a3c5006269c5b77e
--- /dev/null
+++ b/chrome/browser/page_load_metrics/browser_page_track_decider.h
@@ -0,0 +1,47 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_BROWSER_PAGE_TRACK_DECIDER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_BROWSER_PAGE_TRACK_DECIDER_H_
+
+#include "base/macros.h"
+#include "chrome/common/page_load_metrics/page_track_decider.h"
+
+namespace content {
+class NavigationHandle;
+class WebContents;
+} // namespace content
+
+namespace page_load_metrics {
+
+class PageLoadMetricsEmbedderInterface;
+
+class BrowserPageTrackDecider : public PageTrackDecider {
+ public:
+ // embedder_interface, web_contents, and navigation_handle are not owned by
+ // BrowserPageTrackDecider, and must outlive the
+ // BrowserPageTrackDecider.
+ BrowserPageTrackDecider(PageLoadMetricsEmbedderInterface* embedder_interface,
+ content::WebContents* web_contents,
+ content::NavigationHandle* navigation_handle);
+ ~BrowserPageTrackDecider() override;
+
Charlie Harrison 2016/09/14 13:20:05 // PageTrackDecider:
Bryan McQuade 2016/09/14 15:10:58 I think this is a bit redundant in this case, as P
Charlie Harrison 2016/09/14 16:27:32 Nope, just a convention we've been using. Happy to
+ bool HasCommitted() override;
+ bool IsHTTPOrHTTPSUrl() override;
+ bool IsNewTabPageUrl() override;
+ bool IsChromeErrorPage() override;
+ bool IsHTTPErrorPage() override;
+ bool IsHTMLOrXHTMLPage() override;
+
+ private:
+ PageLoadMetricsEmbedderInterface* const embedder_interface_;
+ content::WebContents* const web_contents_;
+ content::NavigationHandle* const navigation_handle_;
+
+ DISALLOW_COPY_AND_ASSIGN(BrowserPageTrackDecider);
+};
+
+} // namespace page_load_metrics
+
+#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_BROWSER_PAGE_TRACK_DECIDER_H_

Powered by Google App Engine
This is Rietveld 408576698