Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Issue 2331053003: Add common page filtering logic for page load metrics. (Closed)
Patch Set: refine interface Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h" 5 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 #include "base/timer/timer.h" 11 #include "base/timer/timer.h"
12 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" 12 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
13 #include "chrome/renderer/page_load_metrics/renderer_page_tracker_predicate.h"
13 #include "chrome/renderer/searchbox/search_bouncer.h" 14 #include "chrome/renderer/searchbox/search_bouncer.h"
14 #include "content/public/renderer/render_frame.h" 15 #include "content/public/renderer/render_frame.h"
15 #include "third_party/WebKit/public/platform/WebURLResponse.h" 16 #include "third_party/WebKit/public/platform/WebURLResponse.h"
16 #include "third_party/WebKit/public/web/WebDataSource.h" 17 #include "third_party/WebKit/public/web/WebDataSource.h"
17 #include "third_party/WebKit/public/web/WebDocument.h" 18 #include "third_party/WebKit/public/web/WebDocument.h"
18 #include "third_party/WebKit/public/web/WebLocalFrame.h" 19 #include "third_party/WebKit/public/web/WebLocalFrame.h"
19 #include "third_party/WebKit/public/web/WebPerformance.h" 20 #include "third_party/WebKit/public/web/WebPerformance.h"
20 #include "url/gurl.h" 21 #include "url/gurl.h"
21 22
22 namespace page_load_metrics { 23 namespace page_load_metrics {
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 if (HasNoRenderFrame()) 80 if (HasNoRenderFrame())
80 return; 81 return;
81 PageLoadTiming timing(GetTiming()); 82 PageLoadTiming timing(GetTiming());
82 page_timing_metrics_sender_->Send(timing); 83 page_timing_metrics_sender_->Send(timing);
83 } 84 }
84 85
85 bool MetricsRenderFrameObserver::ShouldSendMetrics() const { 86 bool MetricsRenderFrameObserver::ShouldSendMetrics() const {
86 if (HasNoRenderFrame()) 87 if (HasNoRenderFrame())
87 return false; 88 return false;
88 const blink::WebLocalFrame* frame = render_frame()->GetWebFrame(); 89 const blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
89 // We only generate historgrams for main frames. 90 // We only track metrics for main frames.
90 if (frame->parent()) 91 if (frame->parent())
91 return false; 92 return false;
92 93
93 const blink::WebDocument& document = frame->document(); 94 const blink::WebDocument& document = frame->document();
94 // Ignore non-HTTP schemes (e.g. chrome://).
95 const GURL& url = document.url();
96 if (!url.SchemeIsHTTPOrHTTPS())
97 return false;
98
99 // Ignore NTP loads.
100 if (SearchBouncer::GetInstance()->IsNewTabPage(url))
101 return false;
102
103 // Ignore non-HTML documents (e.g. SVG). Note that images are treated by
104 // Blink as HTML documents, so to exclude images, we must perform
105 // additional mime type checking below.
106 if (!document.isHTMLDocument() && !document.isXHTMLDocument())
107 return false;
108
109 // Ignore non-HTML mime types (e.g. images).
110 const blink::WebURLResponse& url_response = frame->dataSource()->response(); 95 const blink::WebURLResponse& url_response = frame->dataSource()->response();
111 std::string mime_type = url_response.mimeType().utf8(); 96 RendererPageTrackerPredicate tracker_predicate(&document, &url_response);
112 if (mime_type != "text/html" && mime_type != "application/xhtml+xml") 97 return tracker_predicate.ShouldTrackPage();
113 return false;
114
115 return true;
116 } 98 }
117 99
118 PageLoadTiming MetricsRenderFrameObserver::GetTiming() const { 100 PageLoadTiming MetricsRenderFrameObserver::GetTiming() const {
119 const blink::WebPerformance& perf = 101 const blink::WebPerformance& perf =
120 render_frame()->GetWebFrame()->performance(); 102 render_frame()->GetWebFrame()->performance();
121 103
122 PageLoadTiming timing; 104 PageLoadTiming timing;
123 double start = perf.navigationStart(); 105 double start = perf.navigationStart();
124 timing.navigation_start = base::Time::FromDoubleT(start); 106 timing.navigation_start = base::Time::FromDoubleT(start);
125 if (perf.responseStart() > 0.0) 107 if (perf.responseStart() > 0.0)
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 bool no_frame = !render_frame() || !render_frame()->GetWebFrame(); 158 bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
177 DCHECK(!no_frame); 159 DCHECK(!no_frame);
178 return no_frame; 160 return no_frame;
179 } 161 }
180 162
181 void MetricsRenderFrameObserver::OnDestruct() { 163 void MetricsRenderFrameObserver::OnDestruct() {
182 delete this; 164 delete this;
183 } 165 }
184 166
185 } // namespace page_load_metrics 167 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698