Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(133)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/page_load_metrics/404.html
Issue
2331053003
:
Add common page filtering logic for page load metrics. (Closed)
Patch Set: fixup
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/BUILD.gn
chrome/browser/page_load_metrics/browser_page_track_decider.h
chrome/browser/page_load_metrics/browser_page_track_decider.cc
chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
chrome/common/BUILD.gn
chrome/common/page_load_metrics/page_track_decider.h
chrome/common/page_load_metrics/page_track_decider.cc
chrome/renderer/BUILD.gn
chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
chrome/renderer/page_load_metrics/renderer_page_track_decider.h
chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
chrome/test/data/page_load_metrics/404.html
chrome/test/data/page_load_metrics/404.html.mock-http-headers
View unified diff
|
Download patch
« chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
('K') |
« chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
('k') |
chrome/test/data/page_load_metrics/404.html.mock-http-headers »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
<!doctype html>
2 <html>
1 <html>
3 <body>
2 <body>
3
I am a 404 page!
Charlie Harrison
2016/09/14 13:20:05
hehe :)
hehe :)
4 </body>
4 </body>
5 </html>
5 </html>
OLD
NEW
« chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
('K') |
« chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
('k') |
chrome/test/data/page_load_metrics/404.html.mock-http-headers »
('j') |
no next file with comments »
Issue 2331053003: Add common page filtering logic for page load metrics. (Closed)
Created 4 years, 3 months ago by Bryan McQuade
Modified 4 years, 3 months ago
Reviewers: jochen (gone - plz use gerrit), Charlie Harrison
Base URL:
Comments: 26
This is Rietveld
408576698
Chromium Code Reviews
Issue 2331053003:
Add common page filtering logic for page load metrics. (Closed)
