Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 2331033004: Make cloud_storage_global_lock a python module & import it in py_utils.cloud_storage (Closed)

Created:
4 years, 3 months ago by nednguyen
Modified:
4 years, 3 months ago
Reviewers:
jbudorick
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Make cloud_storage_global_lock a python module & import it in py_utils.cloud_storage This is so that build/android/test_runner.pydeps can pick up this file automatically. BUG=chromium:645720 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0f8747a99ab1380bf05b2276db558ece1aec9648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M common/py_utils/py_utils/cloud_storage.py View 2 chunks +6 lines, -1 line 0 comments Download
D common/py_utils/py_utils/cloud_storage_global_lock View 1 chunk +0 lines, -5 lines 0 comments Download
A + common/py_utils/py_utils/cloud_storage_global_lock.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (7 generated)
jbudorick
this is gross and disgusting and lgtm
4 years, 3 months ago (2016-09-12 20:58:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331033004/1
4 years, 3 months ago (2016-09-12 21:35:56 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 21:54:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698